Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding a retry mechanism to FE testing #1752

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

LiteSun
Copy link
Member

@LiteSun LiteSun commented Apr 11, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Adding a retry mechanism to front-end testing

Refer link: https://docs.cypress.io/guides/guides/test-retries#Introduction

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Apr 11, 2021

Deploy preview for apisix-dashboard ready!

Built with commit 88bb4bb

https://deploy-preview-1752--apisix-dashboard.netlify.app

@codecov-io
Copy link

codecov-io commented Apr 11, 2021

Codecov Report

Merging #1752 (88bb4bb) into master (8b6080d) will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1752      +/-   ##
==========================================
- Coverage   72.45%   72.26%   -0.20%     
==========================================
  Files         132      132              
  Lines        5721     5721              
  Branches      649      649              
==========================================
- Hits         4145     4134      -11     
- Misses       1334     1343       +9     
- Partials      242      244       +2     
Flag Coverage Δ
backend-e2e-test 62.30% <ø> (-0.42%) ⬇️
backend-e2e-test-ginkgo 49.10% <ø> (ø)
backend-unit-test 52.25% <ø> (-0.04%) ⬇️
frontend-e2e-test 73.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/store/storehub.go 71.02% <0.00%> (-3.74%) ⬇️
api/internal/core/storage/etcd.go 47.27% <0.00%> (-3.64%) ⬇️
api/internal/core/store/store.go 87.34% <0.00%> (-1.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6080d...88bb4bb. Read the comment docs.

@juzhiyuan
Copy link
Member

Hi, could you add the documentation link here?

@LiteSun
Copy link
Member Author

LiteSun commented Apr 11, 2021

Hi, could you add the documentation link here?

sure. https://docs.cypress.io/guides/guides/test-retries#Introduction

@juzhiyuan juzhiyuan requested a review from moonming April 12, 2021 01:55
@juzhiyuan juzhiyuan mentioned this pull request Apr 12, 2021
8 tasks
@LiteSun LiteSun merged commit 1d2bc54 into apache:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants