Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect conversion between integer types #1753

Merged
merged 1 commit into from
Apr 12, 2021
Merged

fix: incorrect conversion between integer types #1753

merged 1 commit into from
Apr 12, 2021

Conversation

nic-chen
Copy link
Member

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Use strconv.ParseUint instead of strconv.Atoi and specify the bit size.

Related issues

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Apr 12, 2021 •
edited
Loading

Deploy preview for apisix-dashboard ready!

Built with commit 8fd9bd2

https://deploy-preview-1753--apisix-dashboard.netlify.app

@juzhiyuan juzhiyuan requested review from bzp2010, starsz and tokers April 12, 2021 02:08
Jaycean
Jaycean approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@Jaycean Jaycean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juzhiyuan juzhiyuan merged commit 1fa467a into apache:master Apr 12, 2021
@nic-chen nic-chen deleted the fix-code branch April 13, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaycean Jaycean Jaycean approved these changes

@starsz starsz starsz approved these changes

@tokers tokers tokers approved these changes

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@bzp2010 bzp2010 Awaiting requested review from bzp2010

@gxthrj gxthrj Awaiting requested review from gxthrj

@ShiningRush ShiningRush Awaiting requested review from ShiningRush

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nic-chen @juzhiyuan @tokers @starsz @Jaycean @johzchen