Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: online debug test case #1761

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

juzhiyuan
Copy link
Member

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Due to we merged one PR about the test on OnlineDebug hours ago, it failed due to some changes from the master branch. We need to find the correct element, and everything will go well.

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Apr 13, 2021

Deploy preview for apisix-dashboard ready!

Built with commit c5a746b

https://deploy-preview-1761--apisix-dashboard.netlify.app

@juzhiyuan juzhiyuan mentioned this pull request Apr 13, 2021
9 tasks
@codecov-io
Copy link

Codecov Report

Merging #1761 (c5a746b) into master (1fa467a) will decrease coverage by 19.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1761       +/-   ##
===========================================
- Coverage   71.35%   52.25%   -19.10%     
===========================================
  Files          47       38        -9     
  Lines        3128     2660      -468     
===========================================
- Hits         2232     1390      -842     
- Misses        656     1082      +426     
+ Partials      240      188       -52     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test 52.25% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/utils/version.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/filter/request_id.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/core/entity/entity.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/core/store/storehub.go 0.00% <0.00%> (-71.03%) ⬇️
api/internal/filter/cors.go 0.00% <0.00%> (-66.67%) ⬇️
api/internal/filter/schema.go 0.00% <0.00%> (-55.47%) ⬇️
api/internal/utils/consts/api_error.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/handler/data_loader/route_import.go 27.41% <0.00%> (-37.50%) ⬇️
api/internal/handler/handler.go 42.59% <0.00%> (-35.19%) ⬇️
api/internal/handler/schema/schema.go 66.66% <0.00%> (-33.34%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa467a...c5a746b. Read the comment docs.

@membphis membphis merged commit 266c5f6 into apache:master Apr 13, 2021
@juzhiyuan juzhiyuan deleted the juzhiyuan/fix-online-debug branch April 13, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants