Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added sample for vars in Route & improve Typings #1771

Merged
merged 7 commits into from
Apr 15, 2021

Conversation

juzhiyuan
Copy link
Member

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

According to https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L335

  • added Methods for http_methods;
  • added i18n for Advaned Route Match
  • ...

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Apr 14, 2021

Deploy preview for apisix-dashboard ready!

Built with commit 1927e13

https://deploy-preview-1771--apisix-dashboard.netlify.app

@juzhiyuan juzhiyuan requested review from LiteSun and liuxiran and removed request for LiteSun April 14, 2021 21:48
@juzhiyuan juzhiyuan requested a review from bzp2010 April 14, 2021 23:26
@juzhiyuan juzhiyuan changed the title chore: improve Route module feat: added sample for vars in Route & improve Typings Apr 15, 2021
@codecov-io
Copy link

Codecov Report

Merging #1771 (1927e13) into master (7f041df) will increase coverage by 0.30%.
The diff coverage is 60.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1771      +/-   ##
==========================================
+ Coverage   72.50%   72.81%   +0.30%     
==========================================
  Files         113      119       +6     
  Lines        2695     2836     +141     
  Branches      650      681      +31     
==========================================
+ Hits         1954     2065     +111     
- Misses        741      771      +30     
Flag Coverage Δ
frontend-e2e-test 72.81% <60.71%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Route/constants.ts 100.00% <ø> (ø)
...pages/Route/components/Step1/MatchingRulesView.tsx 51.96% <50.00%> (-0.79%) ⬇️
web/src/pages/Route/service.ts 88.88% <100.00%> (ø)
web/src/pages/Route/transform.ts 72.56% <100.00%> (ø)
web/src/components/Plugin/UI/api-breaker.tsx 62.96% <0.00%> (ø)
web/src/components/Plugin/UI/limit-count.tsx 83.33% <0.00%> (ø)
web/src/components/Plugin/UI/proxy-mirror.tsx 100.00% <0.00%> (ø)
web/src/components/Plugin/UI/limit-req.tsx 100.00% <0.00%> (ø)
...b/src/components/Plugin/UI/referer-restriction.tsx 66.66% <0.00%> (ø)
web/src/components/Plugin/UI/cors.tsx 62.50% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f041df...1927e13. Read the comment docs.

@juzhiyuan juzhiyuan merged commit 1e2e0b7 into apache:master Apr 15, 2021
@juzhiyuan juzhiyuan deleted the juzhiyuan/feat-route branch April 15, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants