-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show correct health checker #1784
Conversation
Deploy preview for apisix-dashboard ready! Built with commit 508abbf |
e810ab9
to
e2512e5
Compare
Found a bug here.
upstream_bug.mov |
Yes, I noticed this case in the morning and fixed it just now. When that case happened, the notification will popup & reset the service_id to the previous value, we'd better now change the original data. Please have a try :) |
</Row> | ||
</Form.Item> | ||
<React.Fragment> | ||
<Form.Item label={formatMessage({ id: 'page.route.service' })} tooltip="绑定服务(Service)对象,以便复用其中的配置。"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i18n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #1784 +/- ##
==========================================
+ Coverage 72.08% 72.14% +0.05%
==========================================
Files 126 125 -1
Lines 2920 2922 +2
Branches 705 703 -2
==========================================
+ Hits 2105 2108 +3
+ Misses 815 814 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Related issues
None
Checklist: