-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: additional flag to force start manager-api #1898
Conversation
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: 6d94496 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/60cedf94464b380007ead5d2 😎 Browse the preview: https://deploy-preview-1898--apisix-dashboard.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #1898 +/- ##
==========================================
- Coverage 66.91% 63.95% -2.97%
==========================================
Files 179 122 -57
Lines 6537 3154 -3383
Branches 753 753
==========================================
- Hits 4374 2017 -2357
+ Misses 1897 1137 -760
+ Partials 266 0 -266
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
c9477ec
to
2635329
Compare
Thanks, Mr. Das :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@starsz please have a look. |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
additional flag
-f
or--force
to force start Manager API with different configuration maybe when a PID file is already existing.Related issues
in continuation with #1814
#1814 (comment)
Checklist: