Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional flag to force start manager-api #1898

Merged
merged 2 commits into from
Jun 24, 2021

Conversation

bisakhmondal
Copy link
Member

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?
additional flag -f or --force to force start Manager API with different configuration maybe when a PID file is already existing.

Related issues

in continuation with #1814
#1814 (comment)

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented May 15, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 6d94496

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/60cedf94464b380007ead5d2

😎 Browse the preview: https://deploy-preview-1898--apisix-dashboard.netlify.app

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2021

Codecov Report

Merging #1898 (c1d715f) into master (e3debe5) will decrease coverage by 2.96%.
The diff coverage is n/a.

❗ Current head c1d715f differs from pull request most recent head 6d94496. Consider uploading reports for the commit 6d94496 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1898      +/-   ##
==========================================
- Coverage   66.91%   63.95%   -2.97%     
==========================================
  Files         179      122      -57     
  Lines        6537     3154    -3383     
  Branches      753      753              
==========================================
- Hits         4374     2017    -2357     
+ Misses       1897     1137     -760     
+ Partials      266        0     -266     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 63.95% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/helpers.tsx 68.85% <0.00%> (-3.28%) ⬇️
api/internal/core/store/validate_mock.go
api/internal/handler/migrate/migrate.go
api/internal/utils/runtime/runtime.go
api/internal/utils/consts/api_error.go
api/internal/core/migrate/conflict.go
api/internal/core/migrate/dataset.go
api/internal/handler/schema/plugin.go
api/internal/handler/ssl/ssl.go
api/internal/handler/tool/tool.go
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3debe5...6d94496. Read the comment docs.

api/internal/utils/pid.go Outdated Show resolved Hide resolved
@bisakhmondal
Copy link
Member Author

Thanks, Mr. Das :)

@juzhiyuan juzhiyuan requested a review from nic-chen June 20, 2021 00:40
Copy link
Contributor

@iamayushdas iamayushdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nic-chen
Copy link
Member

@starsz please have a look.

@juzhiyuan juzhiyuan merged commit 4612d02 into apache:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants