-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: regex & omit vars when no value #1921
Conversation
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: e25940c 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/60af0f034bbe390008828c2c 😎 Browse the preview: https://deploy-preview-1921--apisix-dashboard.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added , thanks for nice suggestion @guoqqqi |
Codecov Report
@@ Coverage Diff @@
## master #1921 +/- ##
==========================================
- Coverage 67.00% 64.13% -2.88%
==========================================
Files 169 122 -47
Lines 6314 3112 -3202
Branches 745 748 +3
==========================================
- Hits 4231 1996 -2235
+ Misses 1832 1116 -716
+ Partials 251 0 -251
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Please update this section with detailed description.
Related issues
fix/resolve #1798
Checklist:
cc - @juzhiyuan @liuxiran @starsz @LiteSun