Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: modify some txt tips to correct grammar #1972

Merged
merged 2 commits into from
Jul 12, 2021
Merged

docs: modify some txt tips to correct grammar #1972

merged 2 commits into from
Jul 12, 2021

Conversation

okaybase
Copy link
Member

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?
Modify some txt tips to correct grammar.

  • Bugfix
  • New feature provided
  • Improve performance
  • Improve document
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix/resolve #Modify some txt tips to correct grammar.

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Jul 10, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 52e0da8

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/60e98931e904c600075edbac

😎 Browse the preview: https://deploy-preview-1972--apisix-dashboard.netlify.app/

@okaybase okaybase changed the title Okaybase okaybase Jul 10, 2021
@okaybase okaybase changed the title okaybase docs: modify some txt tips to correct grammar Jul 10, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1972 (52e0da8) into master (94b1a16) will decrease coverage by 2.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1972      +/-   ##
==========================================
- Coverage   66.79%   64.01%   -2.79%     
==========================================
  Files         182      122      -60     
  Lines        6575     3154    -3421     
  Branches      753      753              
==========================================
- Hits         4392     2019    -2373     
+ Misses       1907     1135     -772     
+ Partials      276        0     -276     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 64.01% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/PluginPage.tsx 98.70% <ø> (ø)
api/internal/handler/global_rule/global_rule.go
api/internal/filter/request_id.go
api/internal/core/storage/etcd.go
.../internal/handler/authentication/authentication.go
api/internal/handler/server_info/server_info.go
api/internal/log/zap.go
api/internal/filter/recover.go
api/cmd/install.go
api/internal/utils/runtime/runtime.go
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b1a16...52e0da8. Read the comment docs.

Copy link
Contributor

@iamayushdas iamayushdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @okaybase 👍🏻

@okaybase
Copy link
Member Author

Thanks for your review. @iamayushdas @juzhiyuan

@iamayushdas
Copy link
Contributor

you can cc @liuxiran @LiteSun

@okaybase
Copy link
Member Author

Okay, thanks for your tip! @iamayushdas 😄

@gxthrj gxthrj merged commit 1e55aa3 into apache:master Jul 12, 2021
@okaybase okaybase deleted the okaybase branch July 13, 2021 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants