-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve placeholder text of the route header override #1973
Conversation
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: 7e6145f 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/60ef1951bccf580008726c6b 😎 Browse the preview: https://deploy-preview-1973--apisix-dashboard.netlify.app |
@@ -48,7 +48,7 @@ export default { | |||
|
|||
'page.route.form.itemRulesRequiredMessage.parameterName': | |||
'Only letters and Numbers are supported, and can only begin with letters', | |||
'page.route.value': 'Value', | |||
'page.route.value': 'Parameter Value', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why to change this, Value
is fine IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, without the Parameter is also ok here. @iamayushdas
Parameter is added only to be consistent with the Chinese version.
cc @juzhiyuan have a look here |
Thanks very much for your careful review! @iamayushdas |
Codecov Report
@@ Coverage Diff @@
## master #1973 +/- ##
==========================================
- Coverage 64.01% 63.95% -0.07%
==========================================
Files 122 122
Lines 3154 3154
Branches 753 753
==========================================
- Hits 2019 2017 -2
- Misses 1135 1137 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Please take time to review, thanks! @juzhiyuan @nic-chen |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Please update this section with detailed description.
Related issues
fix/resolve
Checklist: