Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve placeholder text of the route header override #1973

Merged
merged 3 commits into from
Jul 15, 2021
Merged

docs: improve placeholder text of the route header override #1973

merged 3 commits into from
Jul 15, 2021

Conversation

okaybase
Copy link
Member

@okaybase okaybase commented Jul 11, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  1. Improve placeholder text of the route header override.
  2. Improve label of the route match parameter value.
  3. Correct the title for creating route in the file search-route.spec.js.
  4. Correct the spelling of some words.
  • Bugfix
  • New feature provided
  • Improve performance
  • Improve document
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix/resolve

image

image

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Jul 11, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 7e6145f

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/60ef1951bccf580008726c6b

😎 Browse the preview: https://deploy-preview-1973--apisix-dashboard.netlify.app

@@ -48,7 +48,7 @@ export default {

'page.route.form.itemRulesRequiredMessage.parameterName':
'Only letters and Numbers are supported, and can only begin with letters',
'page.route.value': 'Value',
'page.route.value': 'Parameter Value',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to change this, Value is fine IMO

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, without the Parameter is also ok here. @iamayushdas
Parameter is added only to be consistent with the Chinese version.

image

@iamayushdas
Copy link
Contributor

cc @juzhiyuan have a look here

@okaybase
Copy link
Member Author

Thanks very much for your careful review! @iamayushdas

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #1973 (7e6145f) into master (1e55aa3) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1973      +/-   ##
==========================================
- Coverage   64.01%   63.95%   -0.07%     
==========================================
  Files         122      122              
  Lines        3154     3154              
  Branches      753      753              
==========================================
- Hits         2019     2017       -2     
- Misses       1135     1137       +2     
Flag Coverage Δ
frontend-e2e-test 63.95% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/pages/Route/components/Step1/ProxyRewrite.tsx 94.44% <ø> (ø)
web/src/pages/Route/components/Step3/index.tsx 51.85% <0.00%> (ø)
web/src/helpers.tsx 68.85% <0.00%> (-3.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e55aa3...7e6145f. Read the comment docs.

@okaybase
Copy link
Member Author

Please take time to review, thanks! @juzhiyuan @nic-chen

@juzhiyuan juzhiyuan merged commit 18a4a04 into apache:master Jul 15, 2021
@okaybase okaybase deleted the patch-20210711 branch July 15, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants