-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new route matching param position #1984
Conversation
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: d289af4 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/612da1ce2ad55c0008b0be5e 😎 Browse the preview: https://deploy-preview-1984--apisix-dashboard.netlify.app/ |
Codecov Report
@@ Coverage Diff @@
## master #1984 +/- ##
==========================================
+ Coverage 66.63% 67.25% +0.61%
==========================================
Files 121 121
Lines 3231 3243 +12
Branches 787 790 +3
==========================================
+ Hits 2153 2181 +28
+ Misses 1078 1062 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
55cdad8
to
88b87f6
Compare
Hi @lookbrook , the code looks good to me, would you please add the related test case for this nice feature? you can refer to apisix-dashboard/web/cypress/integration/route/create-edit-duplicate-delete-route.spec.js Line 105 in 9b18c35
to create a route with |
ok, I will try it |
I am studying, please contact me if something need to modify |
also cc @Baoyuantop @iamayushdas @guoqqqi for review, thanks a lot |
web/cypress/integration/route/create-route-with-advanced-matching-conditions.spec.js
Outdated
Show resolved
Hide resolved
LGTM! |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
add a new route matching param position, so that we can use the build-in parameter such as var.server_port
Related issues
fix/resolve #1961
Checklist: