Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consumer): fix add undefined user when view #1987

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

Baoyuantop
Copy link
Contributor

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

The consumer does not have an id attribute, but the id is used when update consumer, which will result in the creation of an undefined user.

Modified to use username for update.

Related issues

fix #1954

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Jul 17, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 382b0db

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/60f2913b4e78aa0007c7d3d6

😎 Browse the preview: https://deploy-preview-1987--apisix-dashboard.netlify.app/

@codecov-commenter
Copy link

Codecov Report

Merging #1987 (382b0db) into master (18a4a04) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1987      +/-   ##
==========================================
- Coverage   64.01%   63.95%   -0.07%     
==========================================
  Files         122      122              
  Lines        3154     3154              
  Branches      753      753              
==========================================
- Hits         2019     2017       -2     
- Misses       1135     1137       +2     
Flag Coverage Δ
frontend-e2e-test 63.95% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Consumer/List.tsx 90.00% <100.00%> (ø)
web/src/helpers.tsx 68.85% <0.00%> (-3.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18a4a04...382b0db. Read the comment docs.

@juzhiyuan juzhiyuan merged commit 0b5196f into apache:master Jul 23, 2021
@Baoyuantop Baoyuantop deleted the fix-consumer-undefined branch August 10, 2021 02:42
@liuxiran liuxiran mentioned this pull request Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard consumer undefined user
6 participants