Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirect uri when session expired #2044

Merged
merged 4 commits into from
Aug 9, 2021
Merged

Conversation

foolwc
Copy link
Contributor

@foolwc foolwc commented Aug 7, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?
Redirect to the right page when session expired and login success.
Related issues
resolve #2029

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Aug 7, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 8caca16

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/611090c83dfed000072c695a

😎 Browse the preview: https://deploy-preview-2044--apisix-dashboard.netlify.app/

@juzhiyuan
Copy link
Member

@foolishlwc Please take a look at the CI :)

cc @iamayushdas to take a look also

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2021

Codecov Report

Merging #2044 (8caca16) into master (0926b59) will decrease coverage by 1.94%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2044      +/-   ##
==========================================
- Coverage   67.68%   65.74%   -1.95%     
==========================================
  Files         181      121      -60     
  Lines        6973     3205    -3768     
  Branches      773      779       +6     
==========================================
- Hits         4720     2107    -2613     
+ Misses       1970     1098     -872     
+ Partials      283        0     -283     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 65.74% <100.00%> (+1.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/app.tsx 100.00% <100.00%> (ø)
web/src/components/Upstream/components/Type.tsx 100.00% <0.00%> (ø)
api/main.go
api/internal/handler/label/label.go
api/internal/core/store/validate.go
api/internal/core/store/store.go
api/internal/core/migrate/dataset.go
api/internal/route.go
api/cmd/service.go
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0926b59...8caca16. Read the comment docs.

@foolwc
Copy link
Contributor Author

foolwc commented Aug 8, 2021

CI problem fixed. Please take a look and help review @juzhiyuan

web/src/app.tsx Outdated Show resolved Hide resolved
@juzhiyuan juzhiyuan requested a review from bzp2010 August 9, 2021 03:04
Copy link
Contributor

@bzp2010 bzp2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuxiran liuxiran merged commit 1cb7cb0 into apache:master Aug 9, 2021
@liuxiran
Copy link
Contributor

liuxiran commented Aug 9, 2021

merged, thanks for your contribution @foolwc

@foolwc foolwc deleted the redirect-uri branch August 10, 2021 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect page is not the last view page when session expired and login
5 participants