-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: websocket enable in route #2052
Conversation
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: 0f4e856 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/6111dc8097b02900077de1cb 😎 Browse the preview: https://deploy-preview-2052--apisix-dashboard.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #2052 +/- ##
==========================================
+ Coverage 65.88% 65.96% +0.07%
==========================================
Files 121 121
Lines 3210 3214 +4
Branches 778 781 +3
==========================================
+ Hits 2115 2120 +5
+ Misses 1095 1094 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
web/cypress/integration/route/create-edit-route-with-redirect-plugin.spec.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Pass the normal
enable_websocket
state to the API.Related issues
fix #1933
Checklist: