-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: limit-* plugin UI form support reject-message field #2097
base: master
Are you sure you want to change the base?
Conversation
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: ed85d12 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/6138381f615ca8000808de69 😎 Browse the preview: https://deploy-preview-2097--apisix-dashboard.netlify.app/ |
Codecov Report
@@ Coverage Diff @@
## master #2097 +/- ##
==========================================
+ Coverage 66.12% 70.86% +4.73%
==========================================
Files 186 60 -126
Lines 7077 3783 -3294
Branches 802 0 -802
==========================================
- Hits 4680 2681 -1999
+ Misses 2111 816 -1295
Partials 286 286
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Hi @iamayushdas , would you please add related test cases for this changes? something like we can file in |
Sure |
any updates? and please fix the conflict file when you have time @iamayushdas thanks |
Its already been fixed by someone. |
|
Hi @iamayushdas , since we have updated schema file uniformly, see: #2117 so you will see there are some conflicts in and for the |
Hi @iamayushdas , you can go on your work when you have time, thinks |
Hi, @iamayushdas. Although the information about reject message has been added in schema.json, the frontend end can't be configured through UI forms, and the input boxes in JSON and YAML can't be automatically filled and prompted for types.
This still needs some modifications. Do you want to continue this PR? |
@iamayushdas Hi, do you have time to finish this PR? |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Please update this section with detailed description.
Related issues
fix/resolve #2094
Checklist: