feat: add retry_timeout for upstream #2106
Conversation
|
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: 0e9dfa7 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/612fafebf00e530007b39a03 😎 Browse the preview: https://deploy-preview-2106--apisix-dashboard.netlify.app |
|
Hi @zaunist , please add the related test case for your feature, you can try to test create/configure upstream with |
Okay, give me some time to add after I learn to write test cases, tomorrow or later |
got you, and you can refer line 60 in https://github.com/apache/apisix-dashboard/blob/master/web/cypress/integration/upstream/create_and_delete_upstream.spec.js, it is a good example, any problem can comment here |
|
When I was writing the test cases, I found some other problems, such as schema.json was not fully updated, so I updated schema.json again |
| weight0: '2', | ||
| port1: '7001', | ||
| weight1: '2', | ||
| retry_timeout: '3', |
There was a problem hiding this comment.
since retry_timeout has been defined, we can use it in the Line60, the same goes for other test data
There was a problem hiding this comment.
there is only a variable defined in data that can be used, but I don't use it, is that right?
There was a problem hiding this comment.
if you define a variable, it would be better to use it, or this variable is useless here
web/cypress/integration/upstream/create_upstream_with_retry_timeout.spec.js
Show resolved
Hide resolved
How careful you are~! and since our version 2.8 will be published soon, we will have a pr to update schema.json consistently, after that you can try to sync the code, thanks very much |
ok :) |
Codecov Report
@@ Coverage Diff @@
## master #2106 +/- ##
==========================================
- Coverage 66.63% 64.93% -1.70%
==========================================
Files 121 60 -61
Lines 3231 3779 +548
Branches 787 0 -787
==========================================
+ Hits 2153 2454 +301
+ Misses 1078 1043 -35
- Partials 0 282 +282
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Hi @zaunist , sorry to cover your code by #2117 at that time we are dealing with the last pr of release 2.8, which was blocked by the CI problem, in order to fix that we rewrite your code without communicating with you since it was too late that night. and thanks very much for your interest and contribution in the project, and there are still many issues to be solved, welcome to take any of them you are interested in. |
Thanks for your comment, maybe next time I can contribute code to the project |
|
Hi @zaunist I found that most of the projects under your name are related to go, so you will be more interested in go related issues right? If so I will also invite you to help related problems, thanks |
|
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Add the retry_timeout field to upstream.
Related issues
fix/resolve #2089
Checklist: