Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Only upload artifact at the release branch #2137

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

imjoey
Copy link
Member

@imjoey imjoey commented Sep 10, 2021

Signed-off-by: imjoey [email protected]

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

For now, every pull-request/push will trigger the upload-artifact CI action, which is actually needed for release only. This PR is going to restrict artifact uploading to perform only on release/** branch.

Related issues

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

Codecov Report

Merging #2137 (93cf221) into master (79012fd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2137   +/-   ##
=======================================
  Coverage   67.48%   67.48%           
=======================================
  Files         126      126           
  Lines        3294     3294           
  Branches      802      802           
=======================================
  Hits         2223     2223           
  Misses       1071     1071           
Flag Coverage Δ
frontend-e2e-test 67.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79012fd...93cf221. Read the comment docs.

Copy link
Member

@Jaycean Jaycean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imjoey imjoey merged commit 5b4e460 into apache:master Sep 10, 2021
@imjoey imjoey deleted the ci/limit_upload_artifact branch September 10, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants