Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Setting default language to english in APISIX Dashboard #2212

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

dileepajayakody
Copy link
Member

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

This PR sets the default language in apisix-dashboard to en-US.

Related issues

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@dileepajayakody dileepajayakody changed the title Setting default language to english in APISIX Dashboard feat: Setting default language to english in APISIX Dashboard Nov 15, 2021
@juzhiyuan juzhiyuan requested a review from bzp2010 November 17, 2021 03:33
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.13%. Comparing base (ad7e3e7) to head (a87f457).
Report is 180 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2212      +/-   ##
==========================================
+ Coverage   65.16%   68.13%   +2.97%     
==========================================
  Files         184      127      -57     
  Lines        7257     3352    -3905     
  Branches      824      824              
==========================================
- Hits         4729     2284    -2445     
+ Misses       2244     1068    -1176     
+ Partials      284        0     -284     
Flag Coverage Δ
backend-e2e-test ?
backend-unit-test ?
frontend-e2e-test 68.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juzhiyuan juzhiyuan requested a review from liuxiran November 17, 2021 05:06
Copy link
Contributor

@bzp2010 bzp2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juzhiyuan juzhiyuan merged commit 07c66ad into apache:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants