Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(route): remove key-auth plugin tip #2261

Merged
merged 2 commits into from
Dec 27, 2021
Merged

feat(route): remove key-auth plugin tip #2261

merged 2 commits into from
Dec 27, 2021

Conversation

zaunist
Copy link
Contributor

@zaunist zaunist commented Dec 22, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

remove the tip in the key-auth configure page when create/configure route 、 service and global plugin.

Related issues

resolve #2092

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@zaunist
Copy link
Contributor Author

zaunist commented Dec 22, 2021

image

@juzhiyuan juzhiyuan requested a review from LiteSun December 24, 2021 01:40
@LiteSun
Copy link
Member

LiteSun commented Dec 27, 2021

The CI failed and just helped you re-run the CI.

@codecov-commenter
Copy link

Codecov Report

Merging #2261 (ecf0fb0) into master (b565f7c) will decrease coverage by 1.71%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2261      +/-   ##
==========================================
- Coverage   69.84%   68.13%   -1.72%     
==========================================
  Files         184      127      -57     
  Lines        7272     3370    -3902     
  Branches      829      829              
==========================================
- Hits         5079     2296    -2783     
+ Misses       1898     1074     -824     
+ Partials      295        0     -295     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 68.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/PluginDetail.tsx 70.52% <100.00%> (+0.17%) ⬆️
api/internal/handler/tool/tool.go
api/internal/handler/healthz/healthz.go
api/internal/core/entity/interface.go
api/internal/handler/server_info/server_info.go
api/internal/conf/conf.go
api/internal/core/store/validate.go
api/internal/filter/cors.go
api/internal/utils/closer.go
api/internal/core/entity/entity.go
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b565f7c...ecf0fb0. Read the comment docs.

@zaunist
Copy link
Contributor Author

zaunist commented Dec 27, 2021

@juzhiyuan Please help me to re run failed CI, thanks.

@juzhiyuan
Copy link
Member

done

2 similar comments
@juzhiyuan
Copy link
Member

done

@juzhiyuan
Copy link
Member

done

@zaunist
Copy link
Contributor Author

zaunist commented Dec 27, 2021

cc @LiteSun @okaybase @bzp2010

@juzhiyuan juzhiyuan requested a review from okaybase December 27, 2021 03:22
Copy link
Member

@guoqqqi guoqqqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Baoyuantop Baoyuantop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to deal with more special cases

@juzhiyuan juzhiyuan merged commit 25ac15a into apache:master Dec 27, 2021
@zaunist zaunist deleted the feat/key-auth branch December 27, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: supporting key-auth plugin to get key from query string
7 participants