-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get current dir error #2283
Conversation
@@ -23,7 +23,8 @@ import ( | |||
"io/ioutil" | |||
"mime/multipart" | |||
"net/http" | |||
"os/exec" | |||
"os" | |||
"path" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to consider separate path for Windows? Ref https://pkg.go.dev/path#pkg-overview, the path
package does not support Windows path.
This package does not deal with Windows paths with drive letters or backslashes;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, use filepath instead, thks for your check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #2283 +/- ##
===========================================
- Coverage 71.13% 59.41% -11.73%
===========================================
Files 57 57
Lines 3905 3905
===========================================
- Hits 2778 2320 -458
- Misses 831 1260 +429
- Partials 296 325 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cc @bzp2010 |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Please update this section with detailed description.
Related issues
fix/resolve #2281
Checklist: