Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get current dir error #2283

Merged
merged 2 commits into from
Jan 12, 2022
Merged

fix: get current dir error #2283

merged 2 commits into from
Jan 12, 2022

Conversation

jwrookie
Copy link
Contributor

@jwrookie jwrookie commented Jan 7, 2022

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix/resolve #2281

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@jwrookie jwrookie changed the title fix:get current dir error fix: get current dir error Jan 7, 2022
@@ -23,7 +23,8 @@ import (
"io/ioutil"
"mime/multipart"
"net/http"
"os/exec"
"os"
"path"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to consider separate path for Windows? Ref https://pkg.go.dev/path#pkg-overview, the path package does not support Windows path.

 This package does not deal with Windows paths with drive letters or backslashes;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, use filepath instead, thks for your check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zaunist backend-e2e-test error, click

can you check it and rerun? thks

@zaunist
Copy link
Contributor

zaunist commented Jan 7, 2022

cc @bzp2010 @starsz @nic-chen

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2022

Codecov Report

Merging #2283 (2aebfd4) into master (7624f2a) will decrease coverage by 11.72%.
The diff coverage is n/a.

❗ Current head 2aebfd4 differs from pull request most recent head 4f7002c. Consider uploading reports for the commit 4f7002c to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2283       +/-   ##
===========================================
- Coverage   71.13%   59.41%   -11.73%     
===========================================
  Files          57       57               
  Lines        3905     3905               
===========================================
- Hits         2778     2320      -458     
- Misses        831     1260      +429     
- Partials      296      325       +29     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo 59.41% <ø> (+0.30%) ⬆️
backend-unit-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/handler/data_loader/route_import.go 3.28% <0.00%> (-64.24%) ⬇️
api/internal/utils/runtime/runtime.go 5.55% <0.00%> (-61.12%) ⬇️
api/internal/core/store/validate_mock.go 0.00% <0.00%> (-60.00%) ⬇️
api/internal/core/store/store.go 64.58% <0.00%> (-25.00%) ⬇️
api/internal/handler/service/service.go 69.35% <0.00%> (-23.39%) ⬇️
api/internal/filter/authentication.go 55.55% <0.00%> (-22.23%) ⬇️
api/internal/handler/global_rule/global_rule.go 68.11% <0.00%> (-17.40%) ⬇️
...pi/internal/handler/plugin_config/plugin_config.go 63.10% <0.00%> (-16.51%) ⬇️
api/internal/handler/route/route.go 64.34% <0.00%> (-15.90%) ⬇️
api/internal/filter/ip_filter.go 60.86% <0.00%> (-15.22%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7624f2a...4f7002c. Read the comment docs.

@zaunist
Copy link
Contributor

zaunist commented Jan 12, 2022

cc @bzp2010

@juzhiyuan juzhiyuan merged commit e0d92c4 into apache:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make api-test fail
6 participants