-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add loading in route page #2287
Conversation
cc @guoqqqi to have a review |
please add the test |
@CP3cham ping |
Codecov Report
@@ Coverage Diff @@
## master #2287 +/- ##
==========================================
- Coverage 69.91% 68.10% -1.81%
==========================================
Files 184 127 -57
Lines 7279 3374 -3905
Branches 830 830
==========================================
- Hits 5089 2298 -2791
+ Misses 1896 1076 -820
+ Partials 294 0 -294
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for your contribution
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
Related issues
fix/resolve #2222
Checklist:
add loading status in route page when the Internet is slow