fix: idle_timeout filed to support set zero value #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2296 +/- ##
==========================================
+ Coverage 69.80% 69.83% +0.02%
==========================================
Files 184 184
Lines 7280 7280
Branches 830 830
==========================================
+ Hits 5082 5084 +2
+ Misses 1902 1900 -2
Partials 296 296
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
starsz
reviewed
Jan 26, 2022
Do it latter. |
zaunist
changed the title
|
cc @nic-chen |
bzp2010
approved these changes
Feb 6, 2022
nic-chen
approved these changes
Feb 7, 2022
starsz
approved these changes
Feb 7, 2022
hongbinhsu
pushed a commit
to fitphp/apix-dashboard
that referenced
this pull request
Feb 23, 2022
* upstream: fix: idle_timeout filed to support set zero value (apache#2296)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
A struct filed will be omit which have
omitemptytag and be set to default value, so we should use pointer to avoid this problem.What changes will this PR take into?
Please update this section with detailed description.
Related issues
fix/resolve #2294
Checklist: