fix: ! (reverse) operator not handled correctly #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Hi, @SkyeYoung can you add the test cases, please refer to: |
I'll try to do it. |
|
@guoqqqi I added test cases, pls have a look. : ) |
Codecov Report
@@ Coverage Diff @@
## master #2364 +/- ##
==========================================
- Coverage 69.91% 68.50% -1.41%
==========================================
Files 184 131 -53
Lines 7279 3420 -3859
Branches 830 828 -2
==========================================
- Hits 5089 2343 -2746
+ Misses 1896 1077 -819
+ Partials 294 0 -294
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
juzhiyuan
approved these changes
Mar 9, 2022
bzp2010
approved these changes
Mar 9, 2022
LiteSun
approved these changes
Mar 10, 2022
hongbinhsu
pushed a commit
to fitphp/apix-dashboard
that referenced
this pull request
Mar 13, 2022
* origin: feat: release 2.11.0 (apache#2361) feat: add data loader framework (apache#2371) feat: improve Consumer module (apache#2327) fix: ! (reverse) operator not handled correctly (apache#2364) chore: modify the select upstream field to upstream (apache#2344) feat: support protobuf on Web (apache#2320) chore: Extract paging related functions into standalone hook (apache#2334) feat: basic support Apache APISIX 2.12.1 (apache#2315) # Conflicts: # web/src/helpers.tsx # web/yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Correct handling ! (reverse) operator
Related issues
fix #2166
Checklist: