-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Turkish Language #2452
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2452 +/- ##
==========================================
- Coverage 70.27% 68.80% -1.47%
==========================================
Files 189 131 -58
Lines 7492 3456 -4036
Branches 845 845
==========================================
- Hits 5265 2378 -2887
+ Misses 1922 1078 -844
+ Partials 305 0 -305
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@Baoyuantop could you point it the location of missing ones? Cause i checked it but didnt find. |
They are under |
Could you check again :) I am apologies for trouble |
Nice job 👍 @anldrms, after verifying that it works, we may need to spend some time checking the accuracy of the translation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. Is there anything to fix that on my side? |
You can follow the hints in the screenshot above to make the fix, which is a spelling error. |
Now its ok i guess there is no parallel in Turkish so i deleted from the sentence. |
* upstream/master: test: remove stale E2E cases (apache#2475) feat: basic support Apache APISIX 2.14.1 (apache#2464) fix: Users can create a Consumer in Dashboard without enabling the plugin (apache#2442) fix: change "Route List" to "Routes" (apache#2453) fix: advance matching in the route create page causes the page to crash (apache#2440) feat: release 2.13 (apache#2458) feat: support Turkish Language (apache#2452) # Conflicts: # web/package.json
This is the initial pull request for adding Turkish language offical support for Apisix Dashboard.