Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid etcd case in cli test #2532

Merged
merged 5 commits into from
Jul 20, 2022

Conversation

bzp2010
Copy link
Contributor

@bzp2010 bzp2010 commented Jul 20, 2022

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Fix a burst error in CLI test.

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022

Codecov Report

Merging #2532 (c53e379) into next (d01b53d) will decrease coverage by 12.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             next    #2532       +/-   ##
===========================================
- Coverage   59.87%   47.85%   -12.03%     
===========================================
  Files         170       37      -133     
  Lines        6036     2535     -3501     
  Branches      861        0      -861     
===========================================
- Hits         3614     1213     -2401     
+ Misses       2264     1164     -1100     
  Partials      158      158               
Flag Coverage Δ
backend-unit-test 47.85% <ø> (ø)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/PluginDetail.tsx
web/src/components/LabelsfDrawer/LabelsDrawer.tsx
web/src/components/Upstream/components/TLS.tsx
web/src/pages/PluginTemplate/components/Step1.tsx
...c/pages/Route/components/ResultView/ResultView.tsx
web/src/pages/Service/transform.ts
web/src/components/Plugin/PluginPage.tsx
web/src/pages/SSL/Create.tsx
...pages/Route/components/CreateStep4/CreateStep4.tsx
...b/src/pages/Proto/components/ProtoDrawer/index.tsx
... and 123 more

@juzhiyuan juzhiyuan merged commit b457804 into apache:next Jul 20, 2022
@bzp2010 bzp2010 self-assigned this Jul 21, 2022
@bzp2010 bzp2010 added bug Something isn't working CI labels Jul 21, 2022
@bzp2010 bzp2010 mentioned this pull request Jul 27, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants