-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set serverUrlMap with env, update cypress, update stylelint #2583
Merged
Merged
Changes from 2 commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
6518f6e
feat: set serverUrlMap using environment variables
SkyeYoung e5be5de
feat: throw unset SERVER_URL_* error
SkyeYoung afb9848
fix: add SERVER_URL_TEST to frontend e2e test workflow
SkyeYoung abb6ff4
fix: SERVER_URL_TEST env
SkyeYoung 42a8e8a
fix: ENV setting
SkyeYoung 09e12e4
fix: correct env variable in ci
SkyeYoung 121ff6c
fix: env variables, update cypress, migrate frontend e2e tests
SkyeYoung c567f68
chore: add license, rm usless deps
SkyeYoung 5cc421e
fix: eslint rules
SkyeYoung bd39c1d
fix: workflow, eslint
SkyeYoung 877fdf8
refactor: rm unnecessary config
SkyeYoung 4c553ca
chore: deps
SkyeYoung d2aac36
refactor: e2e test plugin-schema
SkyeYoung 1d552b6
chore: rb fe e2e wf
SkyeYoung e99ab98
Merge branch 'master' of https://github.com/apache/apisix-dashboard i…
SkyeYoung 42519ef
fix: service-save-paginator-status.cy.js
SkyeYoung 77027a0
fix: route fe e2e tests
SkyeYoung 5448491
refactor: rm node 12.x, add 18.x
SkyeYoung cd7a6fa
refactor: MetaView.tsx
SkyeYoung 45c3ce5
fix: add placeholder span
SkyeYoung 225bebc
fix: error render
SkyeYoung 1992fb4
fix: LabelsDrawer
SkyeYoung 9db9487
fix: fetcher
SkyeYoung be2698b
fix: form instance
SkyeYoung 3a4baf7
fix: swr
SkyeYoung a2cd640
chore: add log
SkyeYoung 44e9996
fix: swr requests
SkyeYoung 7f79d1b
fix: dataSource
SkyeYoung 07cbb3d
refactor: e2e test batch-delete-route
SkyeYoung 8e4fb9e
fix: MetaView
SkyeYoung 1cb0c60
refactor: fe e2e can-skip-upstream-when-select-service-id
SkyeYoung affaff0
Merge branch 'master' of https://github.com/apache/apisix-dashboard i…
SkyeYoung b90cdf5
fix: node build workflow config
SkyeYoung 2f8c520
fix: lint, tests
SkyeYoung 118faa9
fix: e2e plugin, route tests
SkyeYoung 10abc09
chore: update stylelint
SkyeYoung b33b0b8
chore: fix stylelint
SkyeYoung 88aac76
fix: route e2e tests
SkyeYoung 28fbd34
fix: nodejs >18 openssl provider
SkyeYoung 93bc9b3
fix: nodejs >18 openssl
SkyeYoung 59fe0d8
fix: MetaView data fetcher
SkyeYoung a597b86
chore: rm support for node18
SkyeYoung 060e806
fix: LabelsDrawer
SkyeYoung e352860
fix: search-route e2e tests
SkyeYoung 021781d
fix: tests
SkyeYoung a1cc2e7
chore: rm logs
SkyeYoung b6787d8
fix: LabelsDrawer, List
SkyeYoung 64d570e
fix: LabelsDrawer
SkyeYoung cac1280
fix: useEffect
SkyeYoung 1060b54
fix: MetaView
SkyeYoung 0c20daa
fix: list key
SkyeYoung 555555b
fix: LabelsDrawer
SkyeYoung 1249b7a
fix: plugin schema filter
SkyeYoung fde82c0
fix: upstream-create_and_edit_upstream_with_no_nodes.cy.js
SkyeYoung 5334b80
fix: Metaview datasource
SkyeYoung c5b427a
Merge branch 'feat-dotenv' of https://github.com/SkyeYoung/apisix-das…
SkyeYoung 00b49d7
Merge branch 'master' into feat-dotenv
SkyeYoung 1205d3e
chore: rm useless deps
SkyeYoung 0bfb667
chore: rm useless deps
SkyeYoung 6dcb6e9
fix: LabelsDrawer
SkyeYoung faa29b0
chore: reduce plugin e2e test time
SkyeYoung 089ad99
Merge branch 'feat-dotenv' of https://github.com/SkyeYoung/apisix-das…
SkyeYoung 0d64f94
chore: trying to make the test more stable
SkyeYoung cca085a
fix: command
SkyeYoung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,3 +69,5 @@ web/public/monaco-editor/ | |
*.swp | ||
*.swo | ||
|
||
# .env | ||
.env* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but should we use the most generic function call syntax? like
throwPromptError("SERVER_URL_TEST");
, although it still works, it may be confusing for those unfamiliar with it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although we don't seem to have used it much in this project yet, it is actually relatively common, for example in emotion, styled components, graphql...