chore: Move yarn to pnpm #2604
chore: Move yarn to pnpm #2604
Conversation
Move yarn to pnpm3.0
| @@ -49,7 +49,7 @@ jobs: | |||
| run: | | |||
| export VERSION=${{ steps.branch_env.outputs.version }} | |||
| sudo gem install --no-document fpm | |||
| git clone https://github.com/api7/apisix-build-tools.git | |||
| git clone https://github.com/FangSen9000/apisix-build-tools.git | |||
There was a problem hiding this comment.
Note that we should let the API7 community merge my changes to the build script before merging this pr.
api7/apisix-build-tools#232
(if I keep it as it is, the original warehouse that has not been changed will only report an error. In order to prove that my changes are effective, I link to my modified build script warehouse.)
There was a problem hiding this comment.
BZP told me that the build tool can be changed after the dashboard is merged.
I think we can also do this. After all, it only affects the detection of RPM packaging workflow.
| @@ -20,7 +20,7 @@ ARG APISIX_DASHBOARD_VERSION=master | |||
|
|
|||
| RUN set -x \ | |||
| && apk add --no-cache --virtual .builddeps git \ | |||
| && git clone https://github.com/apache/apisix-dashboard.git -b ${APISIX_DASHBOARD_VERSION} /usr/local/apisix-dashboard \ | |||
| && git clone https://github.com/FangSen9000/apisix-dashboard.git -b ${APISIX_DASHBOARD_VERSION} /usr/local/apisix-dashboard \ | |||
There was a problem hiding this comment.
If I keep it as it is, the original warehouse that has not been changed will only report an error. In order to prove that my change is effective, I link to my changed warehouse. Just like RPM workflow. Before merging, please remind me to change it back.
FangSen9000
changed the title
|
Although the previous work has been completed, @SkyeYoung soon merged a new pr. This is a big change, and it conflicts with me. （https://github.com/apache/apisix-dashboard/pull/2583/files） Therefore, based on the latest and modified master, I relocated the dashboard from yarn to pnpm. In fact, the last work was completed seven days ago, and has used pnpm on the dashboard for two weeks. I am waiting for @bzp2010 's comments on the construction tool (the workflow tool script is stored in other Repository.) @Baoyuantop @guoqqqi |
| cache: 'yarn' | ||
| cache-dependency-path: web/yarn.lock | ||
|
|
||
| - name: Install PNPM |
There was a problem hiding this comment.
Why not use the officially provided
https://pnpm.io/continuous-integration#github-actions
There was a problem hiding this comment.
"When downloading the relevant environment, it seems that there are some restrictions. Maybe it can be solved by storing it in the warehouse through some link, but I don‘t find it. This picture is the reason why the three people are useless. Action is prohibited. It clearly meets the requirements he said, but it can't be used."`
@guoqqqi You can look at the pictures. If anyone can solve it, it's best.
There was a problem hiding this comment.
OK, it seems to be due to some permissions of the Apache repository.🤣
| cache-dependency-path: web/yarn.lock | ||
|
|
||
| - name: Install PNPM | ||
| run: npm i -g [email protected] |
| cache-dependency-path: web/yarn.lock | ||
|
|
||
| - name: Install PNPM | ||
| run: npm i -g [email protected] |
|
Please check for failed E2E tests and try to fix them, if there is a failed CI then it will not be possible to agree to merge it |
I will try to refresh again and again until I get the PR exactly right. In addition, you can see that I seem to find the reason why CI can't find elements or contents. This is the case with both yarn and pnpm: the page can't be loaded, and it hasn't been waiting for a long time. The probability of its occurrence is as high as 50%. I put forward an issue with a video inside. |
Feat add tip for plugin editor
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Objective: the purpose of this PR is to introduce advanced and popular pnpm package management tools and use pnpm to download dependency packages faster.
Effect: pnpm will be the next generation package management tool of dashboard. Migrate the package manager from the original yarn to pnpm to reduce dependency installation and compilation time.
Changes: package.json, pnpm-lock.yaml, related GitHub workflow files. The relevant documents have been updated, solutions have been written for possible problems in use, and the workflow is running normally.
The related PR
#2459
Checklist: