fix: ant-table unable to request #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Huanghaiting, can you help get the CI passed? |
HaLibrary
force-pushed
the
fix-loading
branch
from
40dc564 to
96d8d1c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2641 +/- ##
===========================================
- Coverage 68.29% 56.02% -12.28%
===========================================
Files 139 133 -6
Lines 3694 3618 -76
Branches 872 854 -18
===========================================
- Hits 2523 2027 -496
- Misses 1171 1591 +420
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hello, @Huanghaiting It looks like the test failed because some dom names changed due to the upgrade, you need to confirm and change the correct dom names: |
HaLibrary
force-pushed
the
fix-loading
branch
from
5dd98ce to
46fc753
Compare
guoqqqi
reviewed
Oct 21, 2022
web/cypress/e2e/rest/pluginTemplate-create-edit-delete-plugin-template.cy.js
Outdated
Show resolved
Hide resolved
web/cypress/e2e/rest/pluginTemplate-create-plugin-template-with-route.cy.js
Outdated
Show resolved
Hide resolved
web/cypress/e2e/rest/upstream-create_and_edit_upstream_with_no_nodes.cy.js
Outdated
Show resolved
Hide resolved
|
Hi @Huanghaiting, the frontend E2E tests are not very stable, so if there is an error, but it is verified locally by you, please let us know to help you re-run it. |
Baoyuantop
reviewed
Oct 21, 2022
web/cypress/e2e/rest/pluginTemplate-create-edit-delete-plugin-template.cy.js
Outdated
Show resolved
Hide resolved
Baoyuantop
approved these changes
Oct 24, 2022
oil-oil
approved these changes
Oct 25, 2022
bzp2010
approved these changes
Nov 6, 2022
bzp2010
changed the title
|
@Huanghaiting Thank you for your contribution. |
bzp2010
pushed a commit
to bzp2010/apisix-dashboard
that referenced
this pull request
Nov 6, 2022
Co-authored-by: 黄海婷 <[email protected]> (cherry picked from commit b5672b6)
hongbinhsu
added a commit
to fitphp/apix-dashboard
that referenced
this pull request
Nov 7, 2022
* upstream/master: fix: change default CSP value (apache#2601) fix: ant-table unable to request (apache#2641) fix: plugin_config missing on service exist (apache#2657) feat: add etcd store auto re-initialize (apache#2650) feat: add login filter of OpenID-Connect (apache#2608) feat:Configure plug-ins to support this feature (apache#2647) feat: Adding a Loading state to buttons (apache#2630) feat: dashboard support windows (apache#2619) Feat: add tip and preset model for plugin editor, improve e2e stability (apache#2581) docs: add Slack invitation link badge (apache#2617) # Conflicts: # .github/workflows/backend-cli-test.yml # Dockerfile # api/test/shell/cli_test.sh # web/src/components/Footer/index.tsx # web/src/components/RightContent/index.tsx # web/src/pages/ServerInfo/List.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Accoding to this idea ( ant-design/pro-components#1921 ) , I upgraded its version.
Related issues
fix/resolve #2613
Checklist: