-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Plugin disable invalid in API /plugin?all=true #2737
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2737 +/- ##
==========================================
- Coverage 76.40% 74.29% -2.11%
==========================================
Files 139 201 +62
Lines 3759 7840 +4081
Branches 877 877
==========================================
+ Hits 2872 5825 +2953
- Misses 887 1712 +825
- Partials 0 303 +303
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tokers
approved these changes
Feb 15, 2023
bzp2010
approved these changes
Feb 15, 2023
Baoyuantop
pushed a commit
to Baoyuantop/apisix-dashboard
that referenced
this pull request
Mar 22, 2023
Baoyuantop
added a commit
that referenced
this pull request
Mar 23, 2023
* chore: update the year in the NOTICE (#2726) fix: #2724 * fix plugins display in list of routes (#2704) Co-authored-by: litesun <[email protected]> * fix: plugin config page error (#2739) * fix: plugin disable invalid in API /plugin?all=true (#2737) * chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 in /web (#2730) * fix: update URL of the online playground (#2760) * chore: update dependency (#2752) * chore: update dependency --------- Co-authored-by: rongxin <[email protected]> * fix: remove route name length limit (#2759) * fix: change regex template to optional in proxy write (#2762) * fix: ssl table expiration time display (#2763) * feat: add search functionality for id, host, and description fields (#2750) Co-authored-by: Anil Durmus <[email protected]> * fix: disable global plugin invalid (#2757) * feat: support ipv6 in upstream nodes (#2766) * fix: upstream nodes metadata miss (#2773) * fix: remove ssl check in redirect https (#2770) --------- Co-authored-by: Shivam0500 <[email protected]> Co-authored-by: incubator4 <[email protected]> Co-authored-by: litesun <[email protected]> Co-authored-by: Joanthan Chen <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JunXu Chen <[email protected]> Co-authored-by: Xin Rong <[email protected]> Co-authored-by: rongxin <[email protected]> Co-authored-by: Anil Baki Durmus <[email protected]> Co-authored-by: Anil Durmus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why submit this pull request?
What changes will this PR take into?
I tried to disable the plugin in the configuration plugins content of
conf.yaml
when answering the issue question and it didn't work. After reading the code in the plugin section, I found that in a previously submitted PR #1592, the judgment of whether the plugin is enabled or not was removed. So this PR I fixes the problem and support disabling plugins inconf.yaml
plugins.Related issues
fix/resolve #2735
Checklist: