fix: nodes format not works #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #847 +/- ##
==========================================
+ Coverage 42.64% 42.95% +0.31%
==========================================
Files 18 18
Lines 1257 1271 +14
==========================================
+ Hits 536 546 +10
- Misses 630 633 +3
- Partials 91 92 +1
Continue to review full report at Codecov.
|
spacewander
approved these changes
Nov 23, 2020
tokers
reviewed
Nov 23, 2020
| assert.Equal(t, 1, nodes[0].Weight) | ||
| // json encode for client | ||
| res, err := json.Marshal(nodes) | ||
| assert.Nil(t,err) |
There was a problem hiding this comment.
Style: need a space after ,.
| }` | ||
|
|
||
| // bind struct | ||
| var route Route |
There was a problem hiding this comment.
Redundant spaces after var.
| assert.Contains(t, jsonStr, `"weight":0`) | ||
| assert.Contains(t, jsonStr, `"port":8080`) | ||
| assert.Contains(t, jsonStr, `"host":"127.0.0.1"`) | ||
|
|
membphis
reviewed
Nov 23, 2020
| "weight": 0 | ||
| }] | ||
| } | ||
| }` |
tokers
reviewed
Nov 23, 2020
tokers
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
close #786
close #783
two issues are caused by nodes format