-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add middleware to transform error and rename placeholder.txt #899
chore: add middleware to transform error and rename placeholder.txt #899
Conversation
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
=======================================
Coverage 43.03% 43.03%
=======================================
Files 18 18
Lines 1271 1271
=======================================
Hits 547 547
Misses 632 632
Partials 92 92 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.gitkeep looks good to me
@ShiningRush I found that you only added test cases to the routed (uri). should we add test cases in these situations? #568 (comment) |
I have tested the problematic scenes, and there are indeed no problems. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #899 +/- ##
=======================================
Coverage 43.03% 43.03%
=======================================
Files 18 18
Lines 1271 1271
=======================================
Hits 547 547
Misses 632 632
Partials 92 92 ☔ View full report in Codecov by Sentry. |
placeholder.txt
to.gitkeep
, It is more suitable