Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add middleware to transform error and rename placeholder.txt #899

Merged
merged 3 commits into from
Nov 28, 2020

Conversation

ShiningRush
Copy link
Contributor

@codecov-io
Copy link

Codecov Report

Merging #899 (4766942) into master (277ae59) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #899   +/-   ##
=======================================
  Coverage   43.03%   43.03%           
=======================================
  Files          18       18           
  Lines        1271     1271           
=======================================
  Hits          547      547           
  Misses        632      632           
  Partials       92       92           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 277ae59...4766942. Read the comment docs.

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.gitkeep looks good to me

@ShiningRush ShiningRush requested a review from nic-chen November 28, 2020 06:17
@idbeta
Copy link
Contributor

idbeta commented Nov 30, 2020

@ShiningRush I found that you only added test cases to the routed (uri). should we add test cases in these situations? #568 (comment)

@idbeta
Copy link
Contributor

idbeta commented Nov 30, 2020

@ShiningRush I found that you only added test cases to the routed (uri). should we add test cases in these situations? #568 (comment)

I have tested the problematic scenes, and there are indeed no problems.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.03%. Comparing base (277ae59) to head (4766942).
Report is 825 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #899   +/-   ##
=======================================
  Coverage   43.03%   43.03%           
=======================================
  Files          18       18           
  Lines        1271     1271           
=======================================
  Hits          547      547           
  Misses        632      632           
  Partials       92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor][bug] bind params to struct error should response error with 400 status
6 participants