Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix on setting server info to etcd #3075

Merged
merged 3 commits into from
Dec 18, 2020
Merged

fix: fix on setting server info to etcd #3075

merged 3 commits into from
Dec 18, 2020

Conversation

starsz
Copy link
Contributor

@starsz starsz commented Dec 18, 2020 •
edited
Loading

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

I think there is no need to encode the object that calls etcd.set.Because the lua-resty-etcd will serialize it.

@tokers
Copy link
Contributor

tokers commented Dec 18, 2020

@starsz Please supply some contexts.

@starsz starsz mentioned this pull request Dec 18, 2020
Merged
3 tasks
@tokers tokers merged commit 560fca3 into apache:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokers tokers tokers approved these changes

@membphis membphis membphis approved these changes

@spacewander spacewander spacewander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@starsz @tokers @spacewander @membphis