Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support advanced matching based on post form #5409

Merged
merged 11 commits into from
Nov 9, 2021
Merged

feat: support advanced matching based on post form #5409

merged 11 commits into from
Nov 9, 2021

Conversation

bzp2010
Copy link
Contributor

@bzp2010 bzp2010 commented Nov 3, 2021 •
edited by spacewander
Loading

What this PR does / why we need it:

Support for POST form as matching conditions in advanced matching.

Fix #5399

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@bzp2010 bzp2010 added the enhancement New feature or request label Nov 3, 2021
@bzp2010 bzp2010 self-assigned this Nov 3, 2021
@bzp2010 bzp2010 linked an issue Nov 3, 2021 that may be closed by this pull request
Proposal: support advanced matching based on POST form #5399
Closed
@bzp2010 bzp2010 force-pushed the feat-post-arg-match branch 2 times, most recently from 0edd057 to 17cafbc Compare November 4, 2021 16:16
@bzp2010 bzp2010 force-pushed the feat-post-arg-match branch 2 times, most recently from 8dfb356 to e01deee Compare November 4, 2021 16:56
@bzp2010 bzp2010 force-pushed the feat-post-arg-match branch from e01deee to 0a7b2fb Compare November 4, 2021 16:59
@bzp2010 bzp2010 requested a review from spacewander November 5, 2021 03:54
@bzp2010 bzp2010 marked this pull request as ready for review November 5, 2021 04:10
spacewander
spacewander reviewed Nov 5, 2021
View reviewed changes
t/core/request.t Outdated Show resolved Hide resolved
t/core/request.t Outdated Show resolved Hide resolved
t/node/vars.t Outdated Show resolved Hide resolved
apisix/core/ctx.lua Show resolved Hide resolved
@bzp2010 bzp2010 requested a review from spacewander November 5, 2021 09:50
@bzp2010 bzp2010 requested a review from spacewander November 8, 2021 05:35
@bzp2010 bzp2010 requested a review from tzssangglass November 8, 2021 07:35
@spacewander spacewander merged commit c2f5eba into apache:master Nov 9, 2021
@bzp2010 bzp2010 mentioned this pull request Dec 1, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzssangglass tzssangglass tzssangglass approved these changes

@tokers tokers tokers approved these changes

@spacewander spacewander spacewander approved these changes

Assignees

@bzp2010 bzp2010

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: support advanced matching based on POST form
4 participants
@bzp2010 @spacewander @tokers @tzssangglass