-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pretty-printing Decimal numbers #230
Comments
Hi @alamb I'd like to take this issue up if that's ok. Looks like the change should be simple enough - just add the Seems like there is no test in Am I overthinking this a bit? Let me know how to figure this one out. :) Thanks! Reason for tests: I'd like to see the change in action, so to speak. |
@mgill25 the |
Thanks @mgill25 ! As @nevi-me says the pretty print feature is behind a feature flag (as it baloons the dependency stack with something that does not support for WASM builds, as I recall) To answer your question, the pretty print feature is tested here in CI: To test it locally, you can run
|
* Added Decimal support to pretty-print display utility (#230) * Applied cargo fmt to fix linting errors * Added proper printing for decimals based on scale, moved tests to pretty.rs * Applied cargo fmt on pretty test Co-authored-by: Manish Gill <[email protected]>
In the context of apache/datafusion#107 from @joshuataylor
Describe the solution you'd like
It should be possible to pretty-print columns of
DataType::Decimal
type. Pretty printing is used for datafusion and other projects to make human readable versions of Arrow arrays.To do so, we would add support here:
arrow-rs/arrow/src/util/display.rs
Lines 269 to 271 in cf0c7d2
Right now, you get an error such as
The text was updated successfully, but these errors were encountered: