Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick Add Schema::project and RecordBatch::project functions to active_release #1077

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 21, 2021

Automatic cherry-pick of f3e452c

* Allow Schema and RecordBatch to project schemas on specific columns returning a new schema with those columns only

* Addressing PR updates and adding a test for out of range projection

* switch to &[usize]

* fix: clippy and fmt

Co-authored-by: Andrew Lamb <[email protected]>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Dec 21, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1077 (e3aa437) into active_release (31911a4) will increase coverage by 0.00%.
The diff coverage is 89.28%.

❗ Current head e3aa437 differs from pull request most recent head 6908dda. Consider uploading reports for the commit 6908dda to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           active_release    #1077   +/-   ##
===============================================
  Coverage           82.37%   82.37%           
===============================================
  Files                 168      168           
  Lines               49134    49190   +56     
===============================================
+ Hits                40474    40522   +48     
- Misses               8660     8668    +8     
Impacted Files Coverage Δ
arrow/src/record_batch.rs 91.97% <80.00%> (-0.68%) ⬇️
arrow/src/datatypes/schema.rs 72.95% <94.44%> (+6.28%) ⬆️
arrow/src/datatypes/field.rs 53.37% <0.00%> (-0.31%) ⬇️
parquet/src/encodings/encoding.rs 93.52% <0.00%> (-0.20%) ⬇️
arrow/src/array/transform/mod.rs 85.20% <0.00%> (-0.14%) ⬇️
arrow/src/error.rs 20.00% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31911a4...6908dda. Read the comment docs.

@alamb alamb merged commit e0abdb9 into active_release Dec 22, 2021
@alamb alamb deleted the cherry_pick_f3e452cb branch December 22, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants