Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gt dyn scalar kernel #1116

Merged
merged 5 commits into from
Jan 2, 2022

Conversation

matthewmturner
Copy link
Contributor

Which issue does this PR close?

Closes #1113 task gt_dyn_scalar

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2022

Codecov Report

Merging #1116 (75a1ae0) into master (0d825c1) will increase coverage by 0.00%.
The diff coverage is 85.18%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1116   +/-   ##
=======================================
  Coverage   82.32%   82.32%           
=======================================
  Files         168      168           
  Lines       49577    49658   +81     
=======================================
+ Hits        40812    40879   +67     
- Misses       8765     8779   +14     
Impacted Files Coverage Δ
arrow/src/compute/kernels/comparison.rs 90.41% <85.18%> (-0.47%) ⬇️
arrow/src/datatypes/field.rs 53.37% <0.00%> (-0.31%) ⬇️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (-0.23%) ⬇️
arrow/src/array/transform/mod.rs 85.43% <0.00%> (-0.14%) ⬇️
arrow/src/datatypes/datatype.rs 66.80% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d825c1...75a1ae0. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how simple these PRs are both to review as well as their implementation 👨‍🍳 very nice

@matthewmturner matthewmturner force-pushed the add_gt_dyn_scalar_kernel branch from f2c1dda to 75a1ae0 Compare January 1, 2022 15:51
@alamb alamb merged commit 1cbda7a into apache:master Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement dyn scalar comparison kernels
3 participants