Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add neq dyn scalar kernel #1118

Merged
merged 7 commits into from
Jan 2, 2022

Conversation

matthewmturner
Copy link
Contributor

Which issue does this PR close?

Closes #1113 task neq_dyn_scalar

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2022

Codecov Report

Merging #1118 (00a622f) into master (37b843b) will increase coverage by 0.00%.
The diff coverage is 85.18%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1118   +/-   ##
=======================================
  Coverage   82.33%   82.33%           
=======================================
  Files         169      169           
  Lines       49773    49800   +27     
=======================================
+ Hits        40981    41005   +24     
- Misses       8792     8795    +3     
Impacted Files Coverage Δ
arrow/src/compute/kernels/comparison.rs 89.97% <85.18%> (-0.12%) ⬇️
arrow/src/datatypes/datatype.rs 66.38% <0.00%> (-0.43%) ⬇️
arrow/src/array/transform/mod.rs 85.43% <0.00%> (-0.14%) ⬇️
arrow/src/datatypes/field.rs 53.68% <0.00%> (+0.30%) ⬆️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37b843b...00a622f. Read the comment docs.

@matthewmturner matthewmturner force-pushed the add_neq_dyn_scalar_kernel branch from 3977172 to b310c58 Compare January 1, 2022 15:55
@alamb alamb merged commit 985a404 into apache:master Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement dyn scalar comparison kernels
3 participants