Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gt_eq_dyn_utf8_scalar kernel and tests #1124

Merged

Conversation

matthewmturner
Copy link
Contributor

Which issue does this PR close?

Closes #1113 task gt_eq_dyn_utf8_scalar

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 1, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1124 (ca93de7) into master (0d825c1) will increase coverage by 0.00%.
The diff coverage is 87.09%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1124   +/-   ##
=======================================
  Coverage   82.32%   82.32%           
=======================================
  Files         168      168           
  Lines       49577    49608   +31     
=======================================
+ Hits        40812    40839   +27     
- Misses       8765     8769    +4     
Impacted Files Coverage Δ
arrow/src/compute/kernels/comparison.rs 90.75% <87.09%> (-0.13%) ⬇️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (-0.46%) ⬇️
arrow/src/array/transform/mod.rs 85.69% <0.00%> (+0.13%) ⬆️
arrow/src/datatypes/datatype.rs 66.80% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d825c1...ca93de7. Read the comment docs.

Comment on lines +1147 to +1148
/// Perform `left >= right` operation on an array and a numeric scalar
/// value. Supports StringArrays, and DictionaryArrays that have string values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Perform `left >= right` operation on an array and a numeric scalar
/// value. Supports StringArrays, and DictionaryArrays that have string values
/// Perform `left >= right` operation on an array and a `str`
/// value. Supports StringArrays, and DictionaryArrays that have string values

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, to minimize how long this stuff is outstanding, I'll just merge the PRs and then do a final pass through to verify the text and errors

@alamb
Copy link
Contributor

alamb commented Jan 2, 2022

Thanks @matthewmturner

@alamb alamb merged commit 9a592f6 into apache:master Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement dyn scalar comparison kernels
3 participants