Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "update nightly version for miri (#1189)" #1199

Closed
wants to merge 1 commit into from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 18, 2022

Which issue does this PR close?

Closes #1198

Rationale for this change

Master CI checks seem to be broken

What changes are included in this PR?

This reverts commit 548c961.

Are there any user-facing changes?

No (this just controls what version of Rust is used in CI checks)

@codecov-commenter
Copy link

Codecov Report

Merging #1199 (4f615cb) into master (0cc0c05) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 4f615cb differs from pull request most recent head 1dfd04a. Consider uploading reports for the commit 1dfd04a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1199   +/-   ##
=======================================
  Coverage   82.67%   82.68%           
=======================================
  Files         175      175           
  Lines       51561    51561           
=======================================
+ Hits        42630    42632    +2     
+ Misses       8931     8929    -2     
Impacted Files Coverage Δ
parquet_derive/src/parquet_field.rs 66.43% <0.00%> (+0.22%) ⬆️
arrow/src/datatypes/datatype.rs 66.80% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cc0c05...1dfd04a. Read the comment docs.

@alamb
Copy link
Contributor Author

alamb commented Jan 18, 2022

🤔 this did not seem to solve the problem either. Will have to dig deeper maybe later today if no one beats me to it

@gangliao
Copy link
Contributor

@gangliao
Copy link
Contributor

11s
Run rustup toolchain install nightly
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2022-01-18, rust version 1.60.0-nightly (ee5d8d37b 2022-01-17)
info: downloading component 'cargo'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: installing component 'cargo'
info: installing component 'rust-std'
info: installing component 'rustc'

  nightly-x86_64-unknown-linux-gnu installed - rustc 1.60.0-nightly (ee5d8d37b 2022-01-17)

info: checking for self-updates
info: using existing install for 'nightly-x86_64-unknown-linux-gnu'

info: default toolchain set to 'nightly-x86_64-unknown-linux-gnu'
  nightly-x86_64-unknown-linux-gnu unchanged - rustc 1.60.0-nightly (ee5d8d37b 2022-01-17)

info: downloading component 'rustfmt'
info: installing component 'rustfmt'

@jimexist
Copy link
Member

thanks for the change. in my opinion it was hardly the reason. either way just bumping a nightly version in CI wouldn't be the cause of a breakage (if it were, it were merely exposing a false negative).

i remember we had a good fight with miri some months ago. at the end @alamb you had to disable miri for a while...

@alamb
Copy link
Contributor Author

alamb commented Jan 18, 2022

Yeah I agree that the upgrade of nightly version doesn't seem to have caused this issue;
All the checks passed on #1189 -- https://github.com/apache/arrow-rs/pull/1189/checks

I suspect that this is related to some crate being released that was not actually 'semver' compatible in some way

@alamb alamb closed this Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken CI SIMD and wasm checks on master: unknown feature llvm_asm
4 participants