dyn compare for binary array #1238
Conversation
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
… to build binary dictionary array Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1238 +/- ##
==========================================
+ Coverage 82.70% 82.95% +0.24%
==========================================
Files 175 178 +3
Lines 51712 51516 -196
==========================================
- Hits 42770 42736 -34
+ Misses 8942 8780 -162
Continue to review full report at Codecov.
|
| @@ -3843,6 +3960,114 @@ mod tests { | |||
| assert_eq!(neq_dyn_scalar(&array, 8).unwrap(), expected); | |||
| } | |||
|
|
|||
| #[test] | |||
There was a problem hiding this comment.
Perhaps we could get a test with nulls?
There was a problem hiding this comment.
Sure, I will add them
| let large_array = LargeBinaryArray::from_vec( | ||
| vec![b"arrow", b"datafusion", b"flight", b"parquet", &[0xff, 0xf8]], | ||
| ); | ||
| let scalar = "flight".as_bytes(); |
There was a problem hiding this comment.
Perhaps one of these tests could use a non-UTF8 string as the scalar.
There was a problem hiding this comment.
I think this code looks good -- thank you for the contribution @HaoYang670
I agree with @tustvold on the benefits of tests with Null and non utf-8, though that could be done in a follow on if you prefer.
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Which issue does this PR close?
Closes #1108
Rationale for this change
What changes are included in this PR?
typed_compare, so that it supports compare 2 binary arrays*_dyn_binary_scalar.DictionaryArraywith binary values is not supported so far, because I could not find an easy way to build a binary dictionary array. Is there any builder such asStringDictionaryBuildercan be used for binary type?Are there any user-facing changes?