-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance if dictionary kernels, add benchmark and add take_iter_unchecked
#1372
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1372 +/- ##
==========================================
+ Coverage 82.99% 83.02% +0.03%
==========================================
Files 181 181
Lines 52933 53020 +87
==========================================
+ Hits 43932 44022 +90
+ Misses 9001 8998 -3
Continue to review full report at Codecov.
|
The performance looks a bit better? cc @alamb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @viirya -- I think this looks 👍
take_iter_unchecked
Co-authored-by: Andrew Lamb <[email protected]>
Thank you @alamb ! |
Thank you @viirya -- sorry I am backed up on reviews and merging. Always so much to do! |
Thank you @alamb again! |
Which issue does this PR close?
Closes #1371.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?