-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FFI for Arrow C Stream Interface #1384
Merged
Merged
Changes from 6 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
13dad80
Add FFI for Arrow C Stream Interface
viirya 4d4cb7a
Add ArrowArrayStreamReader
viirya 5570fc2
Add test
viirya b256c91
Fix clippy
viirya 415146f
fix format
viirya 62bf805
define error code
viirya 79f5d8a
Regenerate ffi binding using bindgen
viirya 2623b33
Rewrite test
viirya a9bc94c
Remove CStreamInterface
viirya 2560e79
Merge remote-tracking branch 'upstream/master' into issue_1348
viirya 083e014
Fix clippy error
viirya b222a44
Fix more clippy errors
viirya e029f61
For review comment.
viirya 5a35a8e
Fix clippy error
viirya 4b3c91b
Fix clippy error
viirya 99033c1
not run example code in comment
viirya 78444b1
ignore doctest
viirya b0a6ac9
For review
viirya b6efc8d
Fix clippy
viirya 4385684
Merge remote-tracking branch 'upstream/master' into issue_1348
viirya a162c84
For review comment
viirya 35da4f1
For review
viirya 9fad867
Add export_reader_into_raw
viirya 3716c16
For review
viirya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the Stream interface is built on the CDataInterface, what do you think about just reusing the same
CDataInterface
error variant instead of adding a new one?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.