Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up release after cloning source structs #1436

Closed
wants to merge 1 commit into from

Conversation

viirya
Copy link
Member

@viirya viirya commented Mar 13, 2022

Which issue does this PR close?

Closes #1425.

Rationale for this change

What changes are included in this PR?

This is an alternative proposal for #1425.

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Mar 13, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1436 (df126d0) into master (729934c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head df126d0 differs from pull request most recent head 2fe4ae1. Consider uploading reports for the commit 2fe4ae1 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1436   +/-   ##
=======================================
  Coverage   82.67%   82.68%           
=======================================
  Files         185      185           
  Lines       53822    53824    +2     
=======================================
+ Hits        44500    44506    +6     
+ Misses       9322     9318    -4     
Impacted Files Coverage Δ
arrow/src/ffi.rs 85.84% <100.00%> (+0.06%) ⬆️
arrow/src/array/transform/mod.rs 86.43% <0.00%> (+0.11%) ⬆️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (+0.22%) ⬆️
arrow/src/datatypes/field.rs 54.10% <0.00%> (+0.30%) ⬆️
arrow/src/datatypes/datatype.rs 66.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729934c...2fe4ae1. Read the comment docs.

@viirya
Copy link
Member Author

viirya commented Mar 13, 2022

cc @sunchao @alamb @wangfenjin

@viirya viirya closed this Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FFI: ArrowArray::try_from_raw shouldn't clone
2 participants