-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Null buffer accounts for offset
in substring
kernel.
#1704
Conversation
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1704 +/- ##
==========================================
+ Coverage 83.27% 83.29% +0.01%
==========================================
Files 195 195
Lines 55937 55981 +44
==========================================
+ Hits 46584 46629 +45
+ Misses 9353 9352 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HaoYang670
substring
kernel.offset
in substring
kernel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @HaoYang670
(nice tests) |
Which issue does this PR close?
Closes #1639.
Rationale for this change
The null buffer was not aligned with the
offset
of array.What changes are included in this PR?
Use
bit_slice
to align the null buffer.Add tests to test the alignment.
Are there any user-facing changes?
No.