-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve integration test document to follow Arrow C++ repo CI #1742
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1742 +/- ##
==========================================
- Coverage 83.32% 83.31% -0.01%
==========================================
Files 196 196
Lines 55961 55961
==========================================
- Hits 46627 46624 -3
- Misses 9334 9337 +3
Continue to review full report at Codecov.
|
cc @alamb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused why we are documenting what the C++ repo does in the Rust repo? Are you perhaps suggesting we should run with --gold-dirs?
If we want to enable these tests in the C++ repo, we need to pass --gold-dirs test too. Currently although we can pass all producer/consumer tests between C++/Rust according to our doc, it fails --gold-dirs test in C++ repo CI. This update is to reflect this point. |
The C++ repo is used in the rust repo's CI test: arrow-rs/.github/workflows/integration.yml Lines 29 to 35 in 722fcfc
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @viirya
Which issue does this PR close?
Closes #1741.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?