-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude some long-running tests when running under miri #1863
Exclude some long-running tests when running under miri #1863
Conversation
This did not seem to fix CI. Test tests still seem to get killed and then retried by
|
That's actually not the error code I expected if it is an out of memory issue |
Disabling stacked-borrow checking is not perfect, but probably better to run miri with one less check than not running it at all. The check using a lot of cpu and memory is a known problem: rust-lang/miri#1367 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems sensible 👍. We could conceivably run the full MIRI suite as part of release validation, or something, but I also don't feel particularly strongly about this
Codecov Report
@@ Coverage Diff @@
## master #1863 +/- ##
==========================================
- Coverage 83.49% 83.47% -0.03%
==========================================
Files 201 201
Lines 56902 56987 +85
==========================================
+ Hits 47511 47570 +59
- Misses 9391 9417 +26
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Which issue does this PR close?
Closes #1862.
Rationale for this change
Stacked borrow checking uses a lot of cpu and memory resources. Disabling it should make CI much more reliable.
What changes are included in this PR?
Are there any user-facing changes?