-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename weekday
and weekday0
kernels to to num_days_from_monday
and num_days_since_sunday
#2066
Conversation
…and `days_since_sunday`
cc @nl5887 who contributed the original |
Codecov Report
@@ Coverage Diff @@
## master #2066 +/- ##
=======================================
Coverage 83.57% 83.57%
=======================================
Files 222 222
Lines 58244 58244
=======================================
+ Hits 48675 48677 +2
+ Misses 9569 9567 -2
Continue to review full report at Codecov.
|
weekday
and weekday0
kenrels to to num_days_from_monday
and days_since_sunday
weekday
and weekday0
kernels to to num_days_from_monday
and days_since_sunday
Labelled as development process to hide from changelog (as not released) |
Benchmark runs are scheduled for baseline = 4444cb7 and contender = 11445ee. 11445ee is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Labelled as development process to hide from changelog (as not released) I think since though |
weekday
and weekday0
kernels to to num_days_from_monday
and days_since_sunday
weekday
and weekday0
kernels to to num_days_from_monday
and num_days_since_sunday
Which issue does this PR close?
Closes #2065
Rationale for this change
Depending on the usecase sometimes one wants the days of week to start from Sunday or Monday. Dates 🤷
@ovr added the
weekday0
kernel in #2052But now the names are
weekday
andweekday0
which I think might be confusing to the average readerWhat changes are included in this PR?
Rename the kernels to follow the chrono naming scheme
num_days_from_sunday
andnum_days_from_monday
https://docs.rs/chrono/0.4.19/chrono/enum.Weekday.html#method.num_days_from_sunday
https://docs.rs/chrono/0.4.19/chrono/enum.Weekday.html#method.num_days_from_monday
Are there any user-facing changes?
Yes, name of the
compute::kernels::temporal::weekday
(which is present in arrow 18) is renamed tocompute::kernels::temporal::num_days_since_monday