type_id and value_offset are incorrect for sliced UnionArray #2087
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2087 +/- ##
==========================================
+ Coverage 83.68% 83.71% +0.03%
==========================================
Files 224 224
Lines 58826 59005 +179
==========================================
+ Hits 49227 49396 +169
- Misses 9599 9609 +10
Continue to review full report at Codecov.
|
| @@ -383,6 +383,7 @@ mod tests { | |||
| use crate::array::*; | |||
| use crate::buffer::Buffer; | |||
| use crate::datatypes::{DataType, Field}; | |||
| use crate::record_batch::RecordBatch; | |||
There was a problem hiding this comment.
Hm? I need use RecordBatch, otherwise:
error[E0412]: cannot find type `RecordBatch` in this scope
--> arrow/src/array/array_union.rs:994:49
|
994 | fn test_slice_union(record_batch_slice: RecordBatch) {
| ^^^^^^^^^^^ not found in this scope
There was a problem hiding this comment.
Oh, the diff rendered strangely on my phone - made it look like there were no other changes to this file
|
Benchmark runs are scheduled for baseline = a6379fe and contender = 54e9181. 54e9181 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2086.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?