Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix FFI UB with arrays with child data #21

Closed
wants to merge 1 commit into from

Conversation

ritchie46
Copy link
Contributor

Which issue does this PR close?

See description in #20. I put this PR in a WIP state and need some help with this one.

@codecov-commenter
Copy link

Codecov Report

Merging #21 (d058927) into master (463f88f) will increase coverage by 0.02%.
The diff coverage is 93.33%.

❗ Current head d058927 differs from pull request most recent head e9874ad. Consider uploading reports for the commit e9874ad to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   82.49%   82.51%   +0.02%     
==========================================
  Files         162      162              
  Lines       43522    43510      -12     
==========================================
- Hits        35902    35901       -1     
+ Misses       7620     7609      -11     
Impacted Files Coverage Δ
arrow/src/ffi.rs 81.76% <87.50%> (+0.81%) ⬆️
arrow/src/array/ffi.rs 94.73% <100.00%> (+9.60%) ⬆️
arrow/src/array/transform/fixed_binary.rs 84.21% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 463f88f...e9874ad. Read the comment docs.

@jorgecarleitao
Copy link
Member

I am investigating this one.

@ritchie46
Copy link
Contributor Author

I am investigating this one.

Great! I got stuck on this, so hopefully I can learn something from it.

@nevi-me
Copy link
Contributor

nevi-me commented May 3, 2021

I don't know if I'd be useful here, but I'll also have a look at this.

@ritchie46
Copy link
Contributor Author

Close, fixed in #287

@ritchie46 ritchie46 closed this May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants