Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine multiple selections into the same batch size in skip_records #2359

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Combine multiple selections into the same batch size in skip_records #2359

merged 2 commits into from
Aug 8, 2022

Conversation

Ted-Jiang
Copy link
Member

Which issue does this PR close?

Closes #2358 .

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Aug 8, 2022
Ted-Jiang
Ted-Jiang commented Aug 8, 2022
View reviewed changes
parquet/src/arrow/record_reader/mod.rs
@@ -198,12 +198,6 @@ where
self.num_records += buffered_records;
self.num_values += buffered_values;

self.consume_def_levels();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tustvold FYI,
Sometimes like batch_size is = 20, when read 15 records without consume.
Then skip 50 records, finally read 5 records for one batch.
If we call these consume api during skip, we will lose the 15 records.

Do you think remove these is reasonable 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me

tustvold
tustvold approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just some minor nits 👍

parquet/src/arrow/arrow_reader.rs Outdated Show resolved Hide resolved
parquet/src/arrow/arrow_reader.rs Outdated Show resolved Hide resolved
parquet/src/arrow/record_reader/mod.rs
@@ -198,12 +198,6 @@ where
self.num_records += buffered_records;
self.num_values += buffered_values;

self.consume_def_levels();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me

@Ted-Jiang @tustvold
Apply suggestions from code review
fbc5274 
Co-authored-by: Raphael Taylor-Davies <[email protected]>
@tustvold tustvold merged commit ce2bd1e into apache:master Aug 8, 2022
@ursabot
Copy link

ursabot commented Aug 8, 2022

Benchmark runs are scheduled for baseline = f3baeaa and contender = ce2bd1e. ce2bd1e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combine multiple selections into the same batch size in skip_records
3 participants
@Ted-Jiang @ursabot @tustvold