Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize the numeric_cast_with_error #2661

Merged
merged 4 commits into from
Sep 13, 2022
Merged

optimize the numeric_cast_with_error #2661

merged 4 commits into from
Sep 13, 2022

Conversation

liukun4515
Copy link
Contributor

Which issue does this PR close?

follow up of #2649
from the comment: #2649 (comment)

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Sep 6, 2022
@liukun4515 liukun4515 requested a review from tustvold September 6, 2022 03:37
@liukun4515 liukun4515 mentioned this pull request Sep 6, 2022
Merged
liukun4515
liukun4515 commented Sep 6, 2022
View reviewed changes
arrow/src/compute/kernels/cast.rs Outdated
.map(|v| match v {
None => Ok(None),
Some(value) => match num::cast::cast::<T::Native, R::Native>(value) {
let iter =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after #2650 merged, we can use the try_unary to replace below code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @viirya

@liukun4515 liukun4515 mentioned this pull request Sep 6, 2022
Merged
@liukun4515 liukun4515 requested a review from viirya September 12, 2022 00:03
@liukun4515
Copy link
Contributor Author

@viirya @tustvold PTAL

@liukun4515 liukun4515 merged commit f56b573 into apache:master Sep 13, 2022
@ursabot
Copy link

ursabot commented Sep 13, 2022

Benchmark runs are scheduled for baseline = 259a302 and contender = f56b573. f56b573 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

@viirya viirya Awaiting requested review from viirya

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liukun4515 @ursabot @tustvold